Repository navigation
fix(package): drop the space runs in wrapped messages - #43
Merged
Merged
Conversation
Three messages were wrapped by moving the end of the line into the
string, indentation included. package plan wrote "moduleclass tools is
inferred from the package's own classifiers; this tree
carries no other recipe for beautifulsoup4 to take it from" and "binutils
is a stated build requirement and this tree carries no module for it,
so the recipe does not name it" into package.plan.json
and the residual table. The source finding for a tree that declares no
version had the same gap after "the recipe version".
The three strings now continue with a backslash. A unit test in
package_workflow.rs runs the two residual passes on the bs4 PyPI
fixture, and the unverified-version test in artifact_class.rs checks the
whole message. Both fail without the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapped residual messages no longer carry a run of spaces where the source line was wrapped, including the source finding in
src/artifact_class.rs.package planresiduals for an inferred moduleclass and for a dropped build requirement, and the source finding for a tree that declares no version, read as one sentence.residual_summaries_read_as_one_sentencecovers that. The commit has a towncrier fragment. Main has no towncrier yet; #26 (fix/towncrier) adds it.